Min setup for initial commit #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add jfx module
Strip down grpc module I think we do not need a dedicated api module but each domain comes with it's high level api (similar like the CoreApi in Bisq uses the other domain API classes)
I think we need a bit more concrete idea how we integrate the wallets. I assume we do not require dynamic loading for the start and just add the handful of supported wallet apis. But lets see once we get more concrete implementation code.
Add resource dirs
Add resource dirs Fix package names
…to min_setup_for_initial_commit
ghubstan
reviewed
Jun 2, 2021
ghubstan
reviewed
Jun 2, 2021
ghubstan
reviewed
Jun 2, 2021
ghubstan
reviewed
Jun 2, 2021
Might be the next PR after the initial ;-). Just wanted to be conservative with adding stuff until its 100% clear. For instance the Userthread I am not sure to use it that way again, maybe a variation.... |
Sorry seems I have remved too much ;-) . Yes should be part of initial commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.